support indexing request WARC records: #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support customizing --fields for cdxj indexing - support 'req.*' fields which only apply to request records, other headers apply to response/main record - support 'referrer' as special shortcut for 'req.http:referer' - tests: update tests to include 'req.http:cookie' include in cdx - tests: update tests to include 'referrer' in cdx version: bump to 2.4.0
|
Released 2.4.0-beta.0, tested with crawler, appears to be working as intended. |
tw4l
approved these changes
Nov 6, 2024
| }) | ||
| .option("fields", { | ||
| alias: "f", | ||
| describe: "fields to include in index", |
There was a problem hiding this comment.
Suggested change
| describe: "fields to include in index", | |
| describe: "comma-separated list of fields to include in index", |
Since we're not using yarg's array type, might be good to be explicit about the expected format of the input
There was a problem hiding this comment.
Hm, maybe should use the array type, will look.
…params types: add types for cli params
|
Also added type-safety for cli args, made them arrays with defaults |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--fieldsfor cdx-index commandreq.*fields which only apply to request records, both WARC and HTTP, other headers apply to response/main recordreferreras special shortcut forreq.http:referer